On 22.07.2024 11:24 PM, Rob Herring wrote: > On Fri, Jul 19, 2024 at 10:16:36PM +0200, Konrad Dybcio wrote: >> Document the X1E78100-based ThinkPad. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index f08e13b61172..8af56b602de3 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -1038,6 +1038,12 @@ properties: >> - qcom,sm8650-qrd >> - const: qcom,sm8650 >> >> + - items: >> + - enum: >> + - lenovo,thinkpad-t14s >> + - const: qcom,x1e78100 >> + - const: qcom,x1e80100 > > Why 2 chip compatibles? Please explain in the commit msg. Just like other entries in this yaml, the one in the middle is a fuse variant of the latter one. I'll mention this. Konrad