On Tue, Mar 03, 2015 at 10:22:07AM +0000, Pawel Moll wrote: > On Tue, 2015-03-03 at 10:02 +0000, Pawel Moll wrote: > > On Mon, 2015-03-02 at 19:09 +0000, Arun Ramamurthy wrote: > > > > The existing bindings intentionally avoided quoting internal registers - > > > > they are supposed to describe how the hardware is wired up... > > > > > > > > So how about something like "arm,pl11x,tft-invert-clac"? Then the driver > > > > sets the bit or not, depending on the property existance? > > > > > > > Sure, I can change it to two properties called arm,pl11x,tft-invert-clac > > > and arm,pl11x,tft-clksel. Would that be acceptable? > > > > That would be fine by me :-) > > Or (after having a look at the TRM) I should rather say: the invert-clac > is fine by me :-) but the tft-clksel doesn't work, I afraid. > > If I'm not mistaken, there are two problems with it. > > Number one: it's not TFT-specific, is it? So it certainly should not > have the "tft-" bit. > > Number two: setting this bit says "do not use CLCDCLK for the logic; use > HCLK instead", correct? If so, have a look at the clock properties. They > say: > > - clock-names: should contain "clcdclk" and "apb_pclk" > > - clocks: contains phandle and clock specifier pairs for the entries > in the clock-names property. See > > So if your hardware has the reference clock wired to HCLK, and you > defining the clocks as "clcdclk", you are (no offence meant ;-) > lying :-) No. The CLCD block always takes two clock signals - the AHB bus clock (HCLK) for the slave interface, and a CLCD clock. The CLCDCLKSEL is a bit which affects a signal sent to the world outside of the CLCD block, which is used to drive an _external_ multiplexer to select the CLCD clock source. (See the description for bit 5 of the LCDTiming2 register.) So, the clock is still input to the CLCDCLK input, even if it is ultimately derived from HCLK. Remember, the clock API does not deal with names describing the source of the clock, but the consumer of the clock. The consumer in this case is the PL11x CLCD block, which takes a CLCDCLK input. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
