On 21.07.2024 6:40 PM, Abel Vesa wrote: > On 24-07-19 22:16:38, Konrad Dybcio wrote: >> Add support for the aforementioned laptop. That includes: >> >> - input methods, incl. lid switch (keyboard needs the pdc >> wakeup-parent removal hack..) >> - NVMe, WiFi >> - USB-C ports >> - GPU, display >> - DSPs >> >> Notably, the USB-A ports on the side are depenedent on the USB >> multiport controller making it upstream. >> >> At least one of the eDP panels used (non-touchscreen) identifies as >> BOE 0x0b66. >> >> See below for the hardware description from the OEM. >> >> Link: https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099 >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > > Few comments below. Otherwise, LGTM. > > Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 792 +++++++++++++++++++++ >> 2 files changed, 793 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 0e5c810304fb..734a05e04c4a 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -261,6 +261,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk-display-card.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb >> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts > > So what happens for SKUs of this model wil have x1e80100 ? > > Maybe we should stick to x1e80100 ? This one only ships with 78100 [...] >> + vreg_edp_3p3: regulator-edp-3p3 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "VREG_EDP_3P3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + >> + pinctrl-0 = <&edp_reg_en>; >> + pinctrl-names = "default"; >> + >> + regulator-always-on; > > Drop this. Oops! [...] >> + >> + edp_reg_en: edp-reg-en-state { >> + pins = "gpio70"; >> + function = "gpio"; >> + drive-strength = <16>; >> + bias-pull-up; > > bias-disable, maybe ? Yeah, probably Konrad
