On 7/21/24 05:57, Heiko Stuebner wrote:
> The Rockchip variant of the dwc-ahci controller does have and need power-
> domains to work, though the binding does not mention them, making dtccheck
> quite unhappy:
>
> DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb
> /home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: sata@fc800000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml#
>
> Fix that by adding the missing power-domain property to the binding.
>
> Fixes: 85b0e13b19c2 ("dt-bindings: ata: dwc-ahci: add Rockchip RK3588")
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
I queued this as a fix for 6.11. Will send it out once rc1 is out. Thanks !
> ---
> Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> index b5e5767d86988..13eaa8d9a16e5 100644
> --- a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> @@ -35,6 +35,9 @@ properties:
> ports-implemented:
> const: 1
>
> + power-domains:
> + maxItems: 1
> +
> sata-port@0:
> $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port
>
--
Damien Le Moal
Western Digital Research
