On 19/07/2024 17:02, Javier Carrasco wrote:
On 19/07/2024 00:02, Mudit Sharma wrote:
Add support for BH1745, which is an I2C colour sensor with red, green,
blue and clear channels. It has a programmable active low interrupt
pin. Interrupt occurs when the signal from the selected interrupt
source channel crosses set interrupt threshold high or low level.
Interrupt source for the device can be configured by enabling the
corresponding event. Interrupt latch is always enabled when setting
up interrupt.
Add myself as the maintainer for this driver in MAINTAINERS.
Signed-off-by: Mudit Sharma <muditsharma.info@xxxxxxxxx>
Reviewed-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
Reviewed-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Hi Mudit,
a couple of nitpicks inline.
...
Typo in debug message: corresponding. I would recommend you to pass
codespell to checkpatch. It will often catch such things.
Hi Javier,
Thank you for reviewing and the recommendation. Will keep in mind for
future patches.
Best regards,
Mudit Sharma
+ dev_dbg(dev, "No corrosponding gain for requested integration time\n");
+ return ret;
+ }
+
