Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on jic23-iio/togreg] [also build test WARNING on linus/master v6.10 next-20240719] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/marius-cristea-microchip-com/dt-bindings-iio-adc-adding-support-for-PAC194X/20240720-014249 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20240719173855.53261-3-marius.cristea%40microchip.com patch subject: [PATCH v1 2/2] iio: adc: adding support for PAC194X config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20240720/202407202146.evcwKAKb-lkp@xxxxxxxxx/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project ad154281230d83ee551e12d5be48bb956ef47ed3) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240720/202407202146.evcwKAKb-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202407202146.evcwKAKb-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from drivers/iio/adc/pac1944.c:16: In file included from include/linux/acpi.h:14: In file included from include/linux/device.h:32: In file included from include/linux/device/driver.h:21: In file included from include/linux/module.h:19: In file included from include/linux/elf.h:6: In file included from arch/s390/include/asm/elf.h:173: In file included from arch/s390/include/asm/mmu_context.h:11: In file included from arch/s390/include/asm/pgalloc.h:18: In file included from include/linux/mm.h:2258: include/linux/vmstat.h:500:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 500 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 501 | item]; | ~~~~ include/linux/vmstat.h:507:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 507 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 508 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:519:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 519 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 520 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:528:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 528 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 529 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ >> drivers/iio/adc/pac1944.c:1691:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] 1691 | if (time_after(jiffies, info->chip_reg_data.jiffies_tstamp + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1692 | msecs_to_jiffies(PAC1944_MIN_POLLING_TIME_MS))) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/jiffies.h:128:2: note: expanded from macro 'time_after' 128 | (typecheck(unsigned long, a) && \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 129 | typecheck(unsigned long, b) && \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 130 | ((long)((b) - (a)) < 0)) | ~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/adc/pac1944.c:1709:9: note: uninitialized use occurs here 1709 | return ret; | ^~~ drivers/iio/adc/pac1944.c:1691:2: note: remove the 'if' if its condition is always true 1691 | if (time_after(jiffies, info->chip_reg_data.jiffies_tstamp + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1692 | msecs_to_jiffies(PAC1944_MIN_POLLING_TIME_MS))) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/adc/pac1944.c:1686:9: note: initialize the variable 'ret' to silence this warning 1686 | int ret; | ^ | = 0 drivers/iio/adc/pac1944.c:2048:16: warning: variable 'idx' set but not used [-Wunused-but-set-variable] 2048 | int ch, i, j, idx; | ^ 7 warnings generated. vim +1691 drivers/iio/adc/pac1944.c 1683 1684 static int pac1944_retrieve_data(struct pac1944_chip_info *info, u32 wait_time) 1685 { 1686 int ret; 1687 /* 1688 * Check if the minimal elapsed time has passed and if so, 1689 * re-read the chip, otherwise the cached info is just fine 1690 */ > 1691 if (time_after(jiffies, info->chip_reg_data.jiffies_tstamp + 1692 msecs_to_jiffies(PAC1944_MIN_POLLING_TIME_MS))) { 1693 /* 1694 * We need to re-read the chip values 1695 * call the pac1944_reg_snapshot 1696 */ 1697 ret = pac1944_reg_snapshot(info, true, 1698 PAC1944_REFRESH_REG_ADDR, 1699 wait_time); 1700 /* 1701 * Re-schedule the work for the read registers timeout 1702 * (to prevent chip regs saturation) 1703 */ 1704 cancel_delayed_work_sync(&info->work_chip_rfsh); 1705 schedule_delayed_work(&info->work_chip_rfsh, 1706 msecs_to_jiffies(PAC1944_MAX_RFSH_LIMIT_MS)); 1707 } 1708 1709 return ret; 1710 } 1711 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
