Hi Frank,
On Tue, Jul 16, 2024 at 10:39:27PM -0400, Frank Li wrote:
> On Sat, Jun 08, 2024 at 05:16:31PM +0300, Laurent Pinchart wrote:
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> >
> > The ADP5585 is a 10/11 input/output port expander with a built in keypad
> > matrix decoder, programmable logic, reset generator, and PWM generator.
> > This driver supports the chip by modelling it as an MFD device, with two
> > child devices for the GPIO and PWM functions.
> >
> > The driver is derived from an initial implementation from NXP, available
> > in commit 8059835bee19 ("MLK-25917-1 mfd: adp5585: add ADI adp5585 core
> > support") in their BSP kernel tree. It has been extensively rewritten.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Laurent:
> Just saw you already sent out adp5585 patches. Do you plan to
> continue work on this? If you are busy, I can help follow up this.
I just came back from vacation and have a large backlog. Please feel
free to take my v4, rebase it, address any review comments, and send a
v5 if you would like to help merging the driver faster. Please CC me on
the patch submission.
> > ---
> > Changes since v2:
> >
> > - Add missing and remove extraneous headers
> > - Use i2c_get_match_data()
> > - Drop unneeded parentheses
> > - Use GENMASK()
> > - Drop of_match_ptr()
> > - Allow compilation on !OF with COMPILE_TEST
> > - Replace ADP5585_MAN_ID() macro with ADP5585_MAN_ID_MASK
> > - Drop unneeded macro
> >
> > Changes since v1:
> >
> > - Add comment to explain BANK and BIT macros
> > - Drop compatible strings from cells
> > - White space fixes
> > - Fix comparison to NULL
> >
> > Changes compared to the NXP original version:
> >
> > - Add MAINTAINERS entry
> > - Fix compatible strings for child devices
> > - Fix header guards
> > - Use lowercase hex constants
> > - White space fixes
> > - Use module_i2c_driver()
> > - Switch to regmap
> > - Drop I2C device ID table
> > - Drop ADP5585_REG_MASK
> > - Support R5 GPIO pin
> > - Drop dev field from adp5585_dev structure
> > - Check device ID at probe time
> > - Fix register field names
> > - Update copyright
> > - Update license to GPL-2.0-only
> > - Implement suspend/resume
> > ---
> > MAINTAINERS | 2 +
> > drivers/mfd/Kconfig | 12 +++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/adp5585.c | 199 ++++++++++++++++++++++++++++++++++++
> > include/linux/mfd/adp5585.h | 126 +++++++++++++++++++++++
> > 5 files changed, 340 insertions(+)
> > create mode 100644 drivers/mfd/adp5585.c
> > create mode 100644 include/linux/mfd/adp5585.h
[snip]
--
Regards,
Laurent Pinchart
