On Thu, Jul 18, 2024 at 4:12 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Thu, Jul 18, 2024 at 11:44 AM Rob Clark <robdclark@xxxxxxxxx> wrote:
> >
> > From: Rob Clark <robdclark@xxxxxxxxxxxx>
> >
> > Use the correct panel compatible, and wire up enable-gpio. It is wired
> > up in the same way as the x1e80100-crd.
> >
> > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> > ---
> > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > index f569f0fbd1fc..37ef05f8c7e0 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > @@ -592,9 +592,13 @@ &mdss_dp3 {
> >
> > aux-bus {
> > panel {
> > - compatible = "edp-panel";
> > + compatible = "samsung,atna45dc02";
>
> Instead of the above, I believe you should use:
>
> compatible = "samsung,atna45dc02", "samsung,atna33xc20";
>
> ...which makes the dts work without any code changes. This is what we
> decided upon for Stephen's panel [0]
sure, that sounds reasonable.. I only saw the first version because
that is what is in the x1e80100-next branch atm
BR,
-R
> [0] https://lore.kernel.org/r/20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@xxxxxxxxxx/
>
> -Doug
>
