Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Firefly Core-PX30-JD4 on baseboard

[Dragan Simic <dsimic@xxxxxxxxxxx>]

Hello Christopher,

Thanks for the v2.

On 2024-07-18 10:40, Christopher Obbard wrote:
> Add binding for the Firefly Core-PX30-JD4 SoM when used in conjunction
> with the MB-JD4-PX30 baseboard.
>
> Signed-off-by: Christopher Obbard <chris.obbard@xxxxxxxxxxxxx>

Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx>

> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf5..2ad835f4068e2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -148,6 +148,12 @@ properties:
>            - const: engicam,px30-core
>            - const: rockchip,px30
>
> +      - description: Firefly Core-PX30-JD4 on MB-JD4-PX30 baseboard
> +        items:
> +          - const: firefly,px30-jd4-core-mb
> +          - const: firefly,px30-jd4-core
> +          - const: rockchip,px30
> +
>        - description: Firefly Firefly-RK3288
>          items:
>            - enum: