On 2024-07-18 06:20, Dragan Simic wrote:
Hello Conor,
On 2024-07-17 11:37, Conor Dooley wrote:
From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
The Rohm dh2228fv (really the bh2228fv, the compatible in the kernel
has
a typo) does not support frequencies above 10 MHz, nor per the
datasheet appear to use either CPOL or CPHA. I suspect that this
devicetree is abusing the compatible in order to bind the spidev
driver
in Linux. Pretending to have devices on a board for this purpose is
not
acceptable, so remove it.
Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
There's a small typo in the patch subject:
s/unlikly/unlikely/
Ah, sorry for the noise, I see now it's been pointed out already.
---
I could not find any documentation for this board online, and it does
not blatantly say that the device is a "spidev" like other [ab]users,
so
it is possible there's actually a DAC here - but I doubt it is a
bh2228fv given the other incompatibilities.
---
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..9df1cef406c5 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -167,14 +167,6 @@ &spi {
pinctrl-names = "default";
pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
status = "okay";
-
- dh2228fv: dac@0 {
- compatible = "rohm,dh2228fv";
- reg = <0>;
- spi-max-frequency = <24000000>;
- spi-cpha;
- spi-cpol;
- };
};
&u2phy {
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
