On Thu, Jul 18, 2024 at 01:06:46AM +0800, Yuntao Dai wrote: > > > > +examples: > > > > + - | > > > > + #include <dt-bindings/interrupt-controller/irq.h> > > > > + > > > > + mailbox: mailbox@1900000 { > > > > And while you're fixing the things Inochi pointed out, drop the > > "mailbox:" label, you've got no references to it. > > > > Yes, in this patch there is no references to it, but mailbox client node > will need it. > I tested this patch using mailbox-test as the client, like: > " > mailbox-test { > compatible = "mailbox-test"; > mbox-names = "rx", "tx"; > mboxes = <&mailbox 0 1 &mailbox 1 2>; > }; > " > > If you think it is better to drop the label in this patch, I will drop it. Just drop it from the example, you can keep it in the actual dts. We try to keep these examples to a minimum.
Attachment:
signature.asc
Description: PGP signature