Re: [PATCH] ASoC: dt-bindings: ti,pcm512x: Convert to dtschema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/07/2024 09:10, Animesh Agarwal wrote:
> Convert the PCM512x and TAS575x audio CODECs/amplifiers bindings to DT
> schema format. Add missing sound-dai-cells property.
> 
> Cc: Daniel Baluta <daniel.baluta@xxxxxxx>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
> ---


> +
> +required:
> +  - compatible
> +  - reg
> +  - AVDD-supply
> +  - DVDD-supply
> +  - CPVDD-supply
> +
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - ti,tas5754
> +          - ti,tas5756
> +
> +then:
> +  properties:
> +    pll-in:

Please define properties in top-level properties list, not in
conditional. You can narrow the constraints per variant in conditional.


> +      description: GPIO pin used to connect the pll using <1> through <3>. The
> +        device will be configured for clock input on the given pll-in pin.
> +      $ref: /schemas/types.yaml#/definitions/uint32
> +      minimum: 1
> +      maximum: 3


Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux