Re: [PATCH] of/platform: Fix inverted check in of_platform_notify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Geert Uytterhoeven (2024-07-16 02:57:25)
> The check for of_node_check_flag() was accidentally inverted, causing
> i2c-demux-pinctrl to fail on the Koelsch development board:
> 
>     i2c-demux-pinctrl i2c-mux1: failed to setup demux-adapter 0 (-19)
>     i2c-demux-pinctrl i2c-mux2: failed to setup demux-adapter 0 (-19)
>     i2c-demux-pinctrl i2c-mux3: failed to setup demux-adapter 0 (-19)
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with e6ef0000.video
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with e6ef1000.video
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with hdmi-in
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with hdmi-out
> 
> and anything relying on I2C connected to these muxes fails, too.
> 
> Also, loading the 25LC040 DT overlay on Ebisu using the out-of-tree
> of-configfs now fails, too.
> 
> Fixes: 98290f295fbcf18f ("of/platform: Allow overlays to create platform devices from the root node")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---

Thanks. I'm going to fold this into the patch and resend the series.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux