2024. 07. 15. 16:10 keltezéssel, Mark Brown írta:
On Sun, Jul 14, 2024 at 10:23:03PM +0200, egyszeregy@xxxxxxxxxxx wrote:
From: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>
Spidev is a not an ASIC, IC or Sensor specific driver.
It is better to use a simple and generic compatible
string instead of many dummy vendor/product names
which are all just fake.
Signed-off-by: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>
---
drivers/spi/spidev.c | 2 ++
1 file changed, 2 insertions(+)
No, as previously and repeatedly discussed the DT describes the
hardware, not the software that happens to be used to control that
hardware.
You also need to document any new bindings.
If DT describes the hardware, yes this is why need a generic compatible string
for SPIdev driver. SPIdev driver is a typical driver for boards which have just
header pin for SPI connection and it is not defined what IC/Sensor will be
connected on it later.
In normally if a developer start to use an IC/Sensor which has not yet any
driver in Linux he/she should start to make it in a regular way and not
hardcoding these fake compatible strings inside spidev.c and use it for longterm.
By the way, please send some reference link about the rules what you say for DT
and please send the link for SPIdev binding documents, i can not find it, but
you point on it all the time.
devicetree@xxxxxxxxxxxxxxx
Please start a normal discussion about it with devicetree maintainers who can
decided it real what need in this driver code for compatible strings. I do not
think it is a good idea to append these list for +100 fake devices in the future
because you say this is the rules for it.
