Hi Andrew
On 7/15/2024 11:39 AM, Andrew Lunn wrote:
On Mon, Jul 15, 2024 at 11:13:31AM -0700, Mayank Rana wrote:
PCIe designware MSI driver (pcie-designware-msi.c) shall be used without
enabling pcie-designware core drivers (e.g. usage with ECAM driver). Hence
add Kconfig option to enable pcie-designware-msi driver as separate module.
Signed-off-by: Mayank Rana <quic_mrana@xxxxxxxxxxx>
---
drivers/pci/controller/dwc/Kconfig | 8 ++++++++
drivers/pci/controller/dwc/Makefile | 3 ++-
drivers/pci/controller/dwc/pcie-designware-msi.h | 14 ++++++++++++++
3 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 8afacc9..a4c8920 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -6,8 +6,16 @@ menu "DesignWare-based PCIe controllers"
config PCIE_DW
bool
+config PCIE_DW_MSI
+ bool "DWC PCIe based MSI controller"
+ depends on PCI_MSI
+ help
+ Say Y here to enable DWC PCIe based MSI controller to support
+ MSI functionality.
+
Nit picking, but in the commit message you say separate module. But it
is a bool, not a tristate, so it cannot be built as a module.
I don't mean to make this driver as loadable module here. Saying this
I agree that commit text is saying as separate module. I shall update
commit text by replacing "separate module" as "separate driver".
Andrew
Regards,
Mayank
