On 2024-07-13 12:06, Jonathan Cameron wrote: > On Fri, 12 Jul 2024 20:54:02 +0530 > Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx> wrote: > >> Add the compatible string of stk3013 to the existing list. > > Should include how this differs from existing devices such that it doesn't > make sense to use a fallback compatible. STK3013 is a proximity sensor by Sensortek, bearing chipid of 0x31. Despite being marketed as a proximity sensor, it also appears to have ambient light sensing capabilities. Add the compatible string of stk3013 to the existing list, as a part not compatible with other devices. I hope this is good enough. I couldn't find anything more convincing. > >> >> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml >> index f6e22dc9814a..6003da66a7e6 100644 >> --- a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml >> +++ b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml >> @@ -19,6 +19,7 @@ allOf: >> properties: >> compatible: >> enum: >> + - sensortek,stk3013 >> - sensortek,stk3310 >> - sensortek,stk3311 >> - sensortek,stk3335