Hi, On Mon, Jul 15, 2024 at 7:31 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > > <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > > has a reset gpio. The difference is that they have different > > > post_power_delay_ms. > > > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > FWIW things have changed enough between V1 and V2 that you probably > > should have removed Conor's "Acked-by" tag here and waited for him to > > re-add it. > > Yeah, good spot. I wouldn't have acked this version would asking > questions - in v1 it made sense not to have a fallback when "they have a > different post power delay ms", but now there is a fallback. Is the > fallback actually suitable here, or might it be a naive rebase? Does the > ekth6a12nay work with the ekth6915's reset timing? Oh, good point! Yeah, it should be changed so that "ekth6915" isn't a fallback. ...so I will rescind my Reviewed-by until that's handled. :-/ -Doug
