On Fri, Jul 12, 2024 at 02:57:40PM -0400, Frank Li wrote: > Add missing documented compatible strings 'fsl,ls1046a-ahci' and > 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to > 'fsl,ls1043a-ahci'. > > Fix below CHECK_DTB warnings > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci'] > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long These lines should have been wrapped to 75 lines IMO. I will fixup when applying. > > Fixes: e58e12c5c34c ("dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format") > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > Change from v2 to v3 > - Add rob's review tag > - Sort compatible string list > - Add fix tag > - Add two warnings in commit message. > - Add - description: sata controller for ls1012a > > Change from v1 to v2 > - rework commit message to show fix CHECK_DTB warning. > --- > .../devicetree/bindings/ata/fsl,ahci.yaml | 20 ++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml > index 162b3bb5427ed..b58ea5a183082 100644 > --- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml > +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml > @@ -11,13 +11,19 @@ maintainers: > > properties: > compatible: > - enum: > - - fsl,ls1021a-ahci > - - fsl,ls1043a-ahci > - - fsl,ls1028a-ahci > - - fsl,ls1088a-ahci > - - fsl,ls2080a-ahci > - - fsl,lx2160a-ahci > + oneOf: > + - description: sata controller for ls1012a SATA should have been capitalized. I will fixup when applying. Kind regards, Niklas