On Thu, Jul 11, 2024 at 05:08:56PM -0400, Frank Li wrote: > The pwm in imx8qxp mipi subsystem require one extra '32k' clock. So add > compatible string 'imx8qxp-mipi-pwm'. Increase maxItems for clock and > clock-names. Add allOf check to make sure other compatible string keep the > same restriction. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 29 +++++++++++++++++++--- > 1 file changed, 26 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > index 04148198e34d0..750636985f937 100644 > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > @@ -9,9 +9,6 @@ title: Freescale i.MX PWM controller > maintainers: > - Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > -allOf: > - - $ref: pwm.yaml# > - > properties: > "#pwm-cells": > description: > @@ -42,6 +39,7 @@ properties: > - fsl,imx8mp-pwm > - fsl,imx8mq-pwm > - fsl,imx8qxp-pwm > + - fsl,imx8qxp-mipi-pwm I'm not sure I'd do a new compatible for this. Is the instance really different? It's fine if some instances have an optional clock. Rob