On Tue, Jun 25, 2024 at 04:57:52PM -0400, Frank Li wrote: > Add compatible string 'fsl,ls1046a-ahci' and 'fsl,ls1012a-ahci' compatible > string. Allow 'fsl,ls1012a-ahci' fallback to 'fsl,ls1043a-ahci'. > > ls1046a ahci ecc disable bit is difference with other chips. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > .../devicetree/bindings/ata/fsl,ahci.yaml | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml > index 162b3bb5427ed..a244bc603549d 100644 > --- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml > +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml > @@ -11,13 +11,18 @@ maintainers: > > properties: > compatible: > - enum: > - - fsl,ls1021a-ahci > - - fsl,ls1043a-ahci > - - fsl,ls1028a-ahci > - - fsl,ls1088a-ahci > - - fsl,ls2080a-ahci > - - fsl,lx2160a-ahci > + oneOf: > + - items: > + - const: fsl,ls1012a-ahci > + - const: fsl,ls1043a-ahci > + - enum: > + - fsl,ls1021a-ahci > + - fsl,ls1043a-ahci > + - fsl,ls1046a-ahci > + - fsl,ls1028a-ahci > + - fsl,ls1088a-ahci > + - fsl,ls2080a-ahci > + - fsl,lx2160a-ahci > > reg: > minItems: 1 > -- > 2.34.1 > Frank, if the check_dts warning is still there, will you submit a new patch with a better commit message that explains that the patch fixes the initial commit that converted the binding to yaml? Such that DT maintainers can review your v2 patch. Kind regards, Niklas
