> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Friday, July 12, 2024 6:53 AM > To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Jonathan Cameron <jic23@xxxxxxxxxx>; David > Lechner <dlechner@xxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; > Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; > Dimitri Fedrau <dima.fedrau@xxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Hennerich, > Michael <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá > <noname.nuno@xxxxxxxxx> > Subject: Re: [PATCH v6 3/6] dt-bindings: iio: dac: Generalize DAC common > properties > > [External] > > On Thu, Jul 11, 2024 at 07:42:18PM +0800, Kim Seer Paller wrote: > > Introduce a generalized DAC binding that can be used by DACs that have > > similar properties adding output-range-microamp and output-range- > microvolt. > > > > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx> > > --- > > .../devicetree/bindings/iio/dac/dac.yaml | 50 +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/dac/dac.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/dac.yaml > > b/Documentation/devicetree/bindings/iio/dac/dac.yaml > > new file mode 100644 > > index 000000000000..a9787bbcd22b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/dac.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://urldefense.com/v3/__http://devicetree.org/schemas/iio/dac/dac > > > +.yaml*__;Iw!!A3Ni8CS0y2Y!7zJ7L3dzud_vULjCirbZeBLxRAdVf8uNPLanf1xKhpv > u > > +3c3nbMGr57cvS4-EZ4vbO8qbilWaaSXNAT_z$ > > +$schema: > > +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y > > > +aml*__;Iw!!A3Ni8CS0y2Y!7zJ7L3dzud_vULjCirbZeBLxRAdVf8uNPLanf1xKhpvu3 > c > > +3nbMGr57cvS4-EZ4vbO8qbilWaadHw-qDn$ > > + > > +title: IIO Common Properties for DAC Channels > > + > > +maintainers: > > + - Jonathan Cameron <jic23@xxxxxxxxxx> > > + > > +description: > > + A few properties are defined in a common way for DAC channels. > > + > > +properties: > > + $nodename: > > + pattern: "^channel(@[0-9a-f]+)?$" > > + description: > > + A channel index should match reg. > > Drop $nodename. That causes this to apply to every matching node and hence > the failures. > > It is also redundant because you define the node name where you reference > dac.yaml. I've tried to drop $nodename, but it seems it is still facing errors. Errors were also encountered with the suggestion from David. I think I will revert the changes to the original version, as Conor suggested, since it was also following the same pattern as the adc.yaml.
