On 7/10/2024 7:09 PM, Krzysztof Kozlowski wrote:
On 09/07/2024 18:06, Depeng Shao wrote:
Add a PHY configuration sequence for the SM8550 which uses a Qualcomm
Gen 2 version 1.2 CSI-2 PHY.
The PHY can be configured as two phase or three phase in C-PHY or D-PHY
mode. This configuration supports two-phase D-PHY mode.
Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
---
.../qcom/camss/camss-csiphy-3ph-1-0.c | 105 ++++++++++++++++++
1 file changed, 105 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
index 1219a25ec55b..b6d5a27b94a6 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
@@ -324,6 +324,111 @@ csiphy_lane_regs lane_regs_sm8250[] = {
{0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
};
+/* GEN2 1.2 2PH */
+static const struct
+csiphy_lane_regs lane_regs_sm8550[] = {
This should sparkle warnings.
There is no user of it. You must organize your patches in logical junks.
Adding piece of structure without users is not a logical chunk.
Best regards,
Krzysztof
Hi Krzysztof,
Sure, will move this patch to "media: qcom: camss: Add sm8550 support",
It is used in below code.
+ case CAMSS_8550:
+ regs->lane_regs = &lane_regs_sm8550[0];
+ regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8550);
+ regs->offset = 0x1000;
+ break;
default:
Thanks,
Depeng