On 09/07/2024 18:06, Depeng Shao wrote: > Add bindings for qcom,sm8550-camss in order to support the camera > subsystem for sm8550 > > Co-developed-by: Yongsheng Li <quic_yon@xxxxxxxxxxx> > Signed-off-by: Yongsheng Li <quic_yon@xxxxxxxxxxx> > Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx> > --- > .../bindings/media/qcom,sm8550-camss.yaml | 545 ++++++++++++++++++ > 1 file changed, 545 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml > new file mode 100644 > index 000000000000..d002b0ff119e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml > @@ -0,0 +1,545 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,sm8550-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SM8550 Camera Subsystem (CAMSS) > + > +maintainers: > + - Depeng Shao <quic_depengs@xxxxxxxxxxx> > + > +description: | Do not need '|' unless you need to preserve formatting. This wasn't tested so I am not going to perform full review. Look at "Re: [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7280-camss binding" - all comments apply. ... > + > +required: > + - clock-names > + - clocks > + - compatible Keep the same order as in "properties:'. > + - interconnects > + - interconnect-names > + - interrupts > + - interrupt-names > + - iommus > + - power-domains > + - reg > + - reg-names > + - vdda-phy-supply > + - vdda-pll-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,sm8550-camcc.h> > + #include <dt-bindings/clock/qcom,sm8550-gcc.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/qcom-rpmpd.h> > + #include <dt-bindings/clock/qcom,rpmh.h> > + #include <dt-bindings/interconnect/qcom,sm8550-rpmh.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + camss: camss@ace4000 { > + compatible = "qcom,sm8550-camss"; > + > + reg = <0 0x0ace4000 0 0x2000>, > + <0 0x0ace6000 0 0x2000>, > + <0 0x0ace8000 0 0x2000>, > + <0 0x0acea000 0 0x2000>, > + <0 0x0acec000 0 0x2000>, > + <0 0x0acee000 0 0x2000>, > + <0 0x0acf0000 0 0x2000>, > + <0 0x0acf2000 0 0x2000>, > + <0 0x0acb7000 0 0xd00>, > + <0 0x0acb9000 0 0xd00>, > + <0 0x0acbb000 0 0xd00>, > + <0 0x0acca000 0 0xa00>, > + <0 0x0acce000 0 0xa00>, > + <0 0x0acb6000 0 0x1000>, > + <0 0x0ac62000 0 0xf000>, > + <0 0x0ac71000 0 0xf000>, > + <0 0x0ac80000 0 0xf000>, > + <0 0x0acca000 0 0x2800>, > + <0 0x0acce000 0 0x2800>; > + reg-names = "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", These (and many others further) looks misaligned. Best regards, Krzysztof
