Hi Philipp, On Wednesday, 10 July 2024 12:20:20 CEST Philipp Puschmann wrote: > Am 10.07.24 um 12:02 schrieb Diederik de Haas: > > On Wednesday, 10 July 2024 11:33:56 CEST Philipp Puschmann wrote: > >> DMA names are required by of_dma_request_slave_channel function that is > >> called during uart probe. So to enable DMA for uarts add the names as in > >> the RK3568 TRM. > > > > Setting it on channels without flow control apparently causes issues. See > > > > https://lore.kernel.org/linux-rockchip/20240628120130.24076-1-didi.debian@ > > cknow.org/ > Ah is see. The only problem that i have is to enable/disable dmas by having > or not having dma-names properties, where the latter case is followed by > kernel error messages. That is very counterintuitive. I forgot to link to my follow up patch where I added the property to some other Pine64 devices and added a cover letter inviting others to add it to other boards too if that seemed appropriate: https://lore.kernel.org/linux-rockchip/20240705163004.29678-2-didi.debian@xxxxxxxxx/ Maybe this applies to 'your' board too? > Maybe a explicit boolean like dma-broken would be better. That could be > set on dtsi level as default and deleted on board dts if wanted. That seems to invert the logic, which I believe was considered the 'wrong' solution:
