> -----Original Message-----
> From: Peng Fan <peng.fan@xxxxxxx>
> Sent: 2024年7月10日 10:23
> To: Wei Fang <wei.fang@xxxxxxx>; mturquette@xxxxxxxxxxxx;
> sboyd@xxxxxxxxxx; robh@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; festevam@xxxxxxxxx;
> abelvesa@xxxxxxxxxx; Clark Wang <xiaoning.wang@xxxxxxx>
> Cc: linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH 2/3] clk: imx95: enable the clock of NETCMIX block control
>
> > Subject: RE: [PATCH 2/3] clk: imx95: enable the clock of NETCMIX block
> > control
> >
> > > -----Original Message-----
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > > Sent: 2024年7月9日 22:13
> > > To: Wei Fang <wei.fang@xxxxxxx>; mturquette@xxxxxxxxxxxx;
> > > sboyd@xxxxxxxxxx; robh@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> > > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> > festevam@xxxxxxxxx;
> > > abelvesa@xxxxxxxxxx
> > > Cc: linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > > imx@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > > linux-kernel@xxxxxxxxxxxxxxx
> > > Subject: RE: [PATCH 2/3] clk: imx95: enable the clock of NETCMIX
> > block
> > > control
> > >
> > > > Subject: [PATCH 2/3] clk: imx95: enable the clock of NETCMIX block
> > > > control
> > > >
> > > > The NETCMIX block control consists of registers for configuration
> > > > of peripherals in the NETC domain, so enable the clock of NETCMIX
> > > > to support the configuration.
> > > >
> > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > > > ---
> > > > drivers/clk/imx/clk-imx95-blk-ctl.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/clk/imx/clk-imx95-blk-ctl.c
> > > > b/drivers/clk/imx/clk- imx95-blk-ctl.c index
> > > > 74f595f9e5e3..07c70c0a53d4 100644
> > > > --- a/drivers/clk/imx/clk-imx95-blk-ctl.c
> > > > +++ b/drivers/clk/imx/clk-imx95-blk-ctl.c
> > > > @@ -419,6 +419,7 @@ static const struct of_device_id
> > > > imx95_bc_of_match[] = {
> > > > { .compatible = "nxp,imx95-lvds-csr", .data =
> > &lvds_csr_dev_data },
> > > > { .compatible = "nxp,imx95-display-csr", .data =
> > > > &dispmix_csr_dev_data },
> > > > { .compatible = "nxp,imx95-vpu-csr", .data =
> > &vpublk_dev_data },
> > > > + { .compatible = "nxp,imx95-netcmix-blk-ctrl", },
> > >
> > > This should not be added here if no real clocks are included.
> > >
> > This is the first phase, and we are currently prioritizing supporting
> > the RGMII interface of ENETC on upstream. We will add support for
> > multiplexing of the RMII reference clock later.
>
> No, please include clock changes, otherwise, this is just let device tree node
> assigned-clock and power domains setup by platform pre-probe code, and
> nothing else.
>
I saw that "nxp,imx95-display-master-csr" was added here, so I thought adding
"nxp,imx95-netcmix-blk-ctrl" was also fine. Is there any difference between these
two?
>
> >
> > >
> > > > { /* Sentinel */ },
> > > > };
> > > > MODULE_DEVICE_TABLE(of, imx95_bc_of_match);
> > > > --
> > > > 2.34.1
