On 7/9/2024 10:40 PM, Andrew Halaney wrote: > These patches are for netdev, so you need to follow the netdev > rules, i.e. the subject should be have [PATCH net-next] in it, etc as > documented over here: > > https://docs.kernel.org/process/maintainer-netdev.html#tl-dr > Thx very much for the detailed information. > On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: >> QCS9100 uses EMAC version 4, add the relevant defines, rename the >> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) >> and add the new compatible. > > This blurb isn't capturing what's done in this change, please make it > reflect the patch. There is a similar comments on [1] on another patch. Similar comments should be taken care of next time. https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-30-quic_tengfan@xxxxxxxxxxx/ > > Thanks, > Andrew > -- Thx and BRs, Aiqun(Maria) Yu
