On Tue, Jul 09, 2024 at 12:41:02PM +0200, Alexander Dahl wrote: > Am Mon, Jul 08, 2024 at 07:23:47PM +0300 schrieb claudiu beznea: > > On 05.07.2024 09:19, Alexander Dahl wrote: > > > Am Tue, May 28, 2024 at 05:31:09PM +0200 schrieb Alexander Dahl: > > > It's been a while. Is something wrong with the patch? Or with the > > > commit message? > > > > Please CC your patches to proper people (e.g., use > > ./script/get_maintainer.pl). I see no Microchip AT91 maintainers in the > > initial to/cc list of your patch. > > You can be sure I did. This is the list I got on my patch and you see > I CCed everone listed as a _maintainer_ from that output: > > % ./scripts/get_maintainer.pl outgoing/arm-dts-microchip/0001-ARM-dts-microchip-sam9x60-Move-i2c-address-size-to-d.patch > Rob Herring <robh@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Conor Dooley <conor+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> (supporter:ARM/Microchip (AT91) SoC support) > Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> (supporter:ARM/Microchip (AT91) SoC support) > Claudiu Beznea <claudiu.beznea@xxxxxxxxx> (supporter:ARM/Microchip (AT91) SoC support,commit_signer:1/2=50%,authored:1/2=50%,added_lines:32/45=71%,removed_lines:32/45=71%) > > Not sure why Nicolas, Alexandre, and you are listed as "supporter" > only? I think you should have been in the CC list in the first place, > sorry about that. You say only, but actually "supporter" is a stronger wording than "maintainer" as it means that the people are actually paid to look after the platform: S: *Status*, one of the following: Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. See below.. Orphan: No current maintainer [but maybe you could take the role as you write your new code]. Obsolete: Old code. Something tagged obsolete generally means it has been replaced by a better system and you should be using that. As an aside, it might be a bit inaccurate here though, because Claudiu is not paid to look after AT91 and Alexandre might not be either. > Besides, I just noticed arch/arm/boot/dts/microchip/sam9x60.dtsi is > not covered by specific matches in MAINTAINERS file, just through a > generic fallback for all dts. Lines in question are these, sam9 is > not matched: > > F: arch/arm/boot/dts/microchip/at91* > F: arch/arm/boot/dts/microchip/sama* I think this is a hangover from when all arm dts files used to be in arch/arm/boot/dts/, so the patter was needed to only match stuff the lads cared about. Now that arm is like other architectures and has subdirectories for vendors I think these could be simplified: diff --git a/MAINTAINERS b/MAINTAINERS index 691f98fe8ed3..1d2b201563e7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2534,8 +2534,7 @@ L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers) S: Supported W: http://www.linux4sam.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git -F: arch/arm/boot/dts/microchip/at91* -F: arch/arm/boot/dts/microchip/sama* +F: arch/arm/boot/dts/microchip/ F: arch/arm/include/debug/at91.S F: arch/arm/mach-at91/ F: drivers/memory/atmel* > > Okay for the next time I will also CC supporters, but I found the > output of get_maintainer.pl some kind of confusing here. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
