Hi, On Thu, Jul 4, 2024 at 1:03 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Thu, Jul 4, 2024 at 6:50 AM Cong Yang > <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > These panels have some common cmds (e0h~e3h,80h), let's break > > them into helper functions. > > > > Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > This is a good start! :) > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > If you get time one of these days, see if you can add some defines for > the other vendor DCS commands as well, but no hurry with that, > let's merge this series first. I agree with Linus. It would be great to take this further, but this is a good start and I'm OK with it merging. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> I'd tend to assume that Neil will merge this series with the various Acks/Reviews. If I see it hasn't been merged after a while or Neil says he's busy then I'm happy to land it. -Doug