> > > eth0: ethernet@1fb50000 { > > > compatible = "airoha,en7581-eth"; > > > reg = <0 0x1fb50000 0 0x2600>, > > > <0 0x1fb54000 0 0x2000>, > > > <0 0x1fb56000 0 0x2000>; > > > reg-names = "fe", "qdma0", "qdma1"; > > > > > > resets = <&scuclk EN7581_FE_RST>, > > > <&scuclk EN7581_FE_PDMA_RST>, > > > <&scuclk EN7581_FE_QDMA_RST>, > > > <&scuclk EN7581_XSI_MAC_RST>, > > > <&scuclk EN7581_DUAL_HSI0_MAC_RST>, > > > <&scuclk EN7581_DUAL_HSI1_MAC_RST>, > > > <&scuclk EN7581_HSI_MAC_RST>, > > > <&scuclk EN7581_XFP_MAC_RST>; > > > reset-names = "fe", "pdma", "qdma", "xsi-mac", > > > "hsi0-mac", "hsi1-mac", "hsi-mac", > > > "xfp-mac"; > > > > > > interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; > > > > > > status = "disabled"; > > > > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > gdm1: mac@1 { > > > compatible = "airoha,eth-mac"; > > > reg = <1>; > > > phy-mode = "internal"; > > > status = "disabled"; > > > > > > fixed-link { > > > speed = <1000>; > > > full-duplex; > > > pause; > > > }; > > > }; > > > }; > > > > > > I am using phy related binding for gdm1:mac@1 node. > > Hi Lorenzo Hi Andrew, > > phy-mode is a MAC property, not a PHY property. Same for > fixed-link. These are in ethernet-controller.yaml. ack > > You sometimes have an network controller IP which has multiple MACs > and some shared infrastructure. You would typically describe the > shared infrastructure at the top level. The MACs are then listed as > children, and they make use of ethernet-controller.yaml, and that is > where all the network specific properties are placed. Is that what you > are trying to do here? yep, exactly. Here we have multiple mac nodes that represent the real ethernet controllers (e.g. used as DSA cpu port). I will use the ethernet-controller.yaml just for the mac childs. Regards, Lorenzo > > Andrew
Attachment:
signature.asc
Description: PGP signature