On 08/07/2024 14:08, Yao Zi wrote: > cv1800-usb-phy driver supports USB 2.0 phys integrated in Sophgo > Cv1800/SG200x SoCs. Add YAML schema for its binding. > > Signed-off-by: Yao Zi <ziyao@xxxxxxxxxxx> A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > +properties: > + compatible: > + enum: > + - sophgo,cv1800-usb-phy > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: phy > + - const: pin > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: apb > + - const: 125m > + - const: 33k > + - const: 12m All these three should have rather some logical name, not frequency. > + > + "#phy-cells": > + const: 0 > + > + dr_role: No underscores in node names, missing vendor prefix (unless it is generic property), missing description. Please do not invent new properties like this. You probably wanted to reference usb-drd? Best regards, Krzysztof
