RE: [EXT] Re: [PATCH v4 2/5] dt-bindings: arm: fsl: add imx-se-fw binding doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Monday, July 8, 2024 4:54 PM
> To: Pankaj Gupta <pankaj.gupta@xxxxxxx>; Jonathan Corbet
> <corbet@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Shawn Guo
> <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>;
> Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Fabio Estevam
> <festevam@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [EXT] Re: [PATCH v4 2/5] dt-bindings: arm: fsl: add imx-se-fw
> binding doc
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 08/07/2024 13:19, Pankaj Gupta wrote:
> >>>> 4 mailboxes? This cannot be different.
> >>> mbox-names can have any of the above mentioned 4 values.
> >>> And  two values are minimum, required.
> >>
> >> No, I said it cannot be different. If two are minimum, then you can
> >> have here 4, right? But earlier you said you can have only 2. It does not
> make any sense.
> >
> > Understood.  Will fix this with following changes.
> >
> > -      - const: tx
> > -      - const: rx
> > -      - const: txdb
> > -      - const: rxdb
> > -    minItems: 2
> > +      - enum:
> > +          - tx
> > +          - txdb
> > +      - enum:
> > +          - rx
> > +          - rxdb
> 
> OK, this is now clear and answer is also clear:
> No, you cannot have different names, except some rare cases.
> Please explain why this should be an exception?

The name suggests the type of protocol for:
- sending:    tx or txdb (with doorbell).
- receiving:  rx & rxdb  (with doorbell).

NXP IP SECO on i.MX8DXL/8QXP supports txdb & rxdb. Hence added these names.

It is just for readability to understand from platform's DTSI file.


> 
> Best regards,
> Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux