On 08/07/2024 08:04, Yang Li wrote: >>> + >>> +required: >>> + - compatible >>> + - clocks >>> + - clock-names >>> + - amlogic,chip-enable-gpios >>> + - amlogic,bt-enable-gpios >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/gpio/gpio.h> >>> + wcn_pwrseq { >> No underscores in node names, generic node names. >> >> There is no device as "pwrseq". I also do not get what "wcn" means here. > > Yes, I understand. > > Can I change "wcn_pwrseq" to "pmu", and do I need to change the binding What is pmu for your device? What is this device in the first place you are documenting? Where is the datasheet? > file name to "amlogic,w155s2-pmu" Yes, compatible should also match proper device. Best regards, Krzysztof