On Mon, Jul 01, 2024 at 06:49:15PM +0200, Krzysztof Kozlowski wrote:
> Bindings expect the LED and GPIO keys node names to follow certain
> pattern, see dtbs_check warnings:
>
> nuvoton-wpcm450-supermicro-x9sci-ln4f.dtb: gpio-keys: 'uid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)...
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Looks good, thanks!
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> .../dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> index b78c116cbc18..edb907f740bf 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> @@ -34,7 +34,7 @@ gpio-keys {
> pinctrl-names = "default";
> pinctrl-0 = <&key_pins>;
>
> - uid {
> + button-uid {
> label = "UID button";
> linux,code = <KEY_HOME>;
> gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> @@ -46,12 +46,12 @@ gpio-leds {
> pinctrl-names = "default";
> pinctrl-0 = <&led_pins>;
>
> - uid {
> + led-uid {
> label = "UID";
> gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> };
>
> - heartbeat {
> + led-heartbeat {
> label = "heartbeat";
> gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
> };
> --
> 2.43.0
>
