On 05/07/2024 12:42, Shreeya Patel wrote: > On Friday, July 05, 2024 15:20 IST, Marek Vasut <marex@xxxxxxx> wrote: > >> The "ltr,ltrf216a" compatible string is not documented in DT binding >> document, remove it. >> >> Signed-off-by: Marek Vasut <marex@xxxxxxx> >> --- >> Cc: Conor Dooley <conor+dt@xxxxxxxxxx> >> Cc: Jonathan Cameron <jic23@xxxxxxxxxx> >> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> >> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> >> Cc: Marek Vasut <marex@xxxxxxx> >> Cc: Rob Herring <robh@xxxxxxxxxx> >> Cc: Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> Cc: linux-iio@xxxxxxxxxxxxxxx >> --- >> drivers/iio/light/ltrf216a.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c >> index 68dc48420a886..78fc910fcb18c 100644 >> --- a/drivers/iio/light/ltrf216a.c >> +++ b/drivers/iio/light/ltrf216a.c >> @@ -528,7 +528,6 @@ MODULE_DEVICE_TABLE(i2c, ltrf216a_id); >> >> static const struct of_device_id ltrf216a_of_match[] = { >> { .compatible = "liteon,ltrf216a" }, >> - { .compatible = "ltr,ltrf216a" }, >> {} > > This compatible string with a different vendor prefix was added for a specific reason. > Please see the commit message of the following patch :- > https://lore.kernel.org/all/20220511094024.175994-2-shreeya.patel@xxxxxxxxxxxxx/ And adding this specific compatible was clearly NAKed: https://lore.kernel.org/all/20220516170406.GB2825626-robh@xxxxxxxxxx/ yet you still added it. That's a deliberate going around maintainer's decision. > > We were very well aware that not documenting this was going to generate a warning so You *CANNOT* have undocumented compatibles. > we tried to fix that with a deprecated tag but it was NAKd by Rob. What we understood Because the driver was NAKed obviously as well. > from his last message was that it wasn't necessary to fix the DT warning. I am quite angry that maintainer tells you something, but you push your patch through because apparently you need to fulfill your project requirements. Best regards, Krzysztof