On 7/5/24 08:49, Krzysztof Kozlowski wrote: > On 04/07/2024 22:02, Adam Skladowski wrote: >> This series introduce new ICC drivers for some legacy socs >> while at it also updates a bit of qcs404 driver which seems >> to not receive much attention lately. >> Please take in consideration i do not own any qcs404 board >> so i cannot test anything else than if it compiles. >> >> Changes since v1 >> ================ >> 1. Reworded commit messages >> 2. Adjusted yamls. >> 3. Adjusted examples. > Adjusted to what? This is supposed to be specific. > > BTW, you use here odd email address, so: > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > </form letter> > > Best regards, > Krzysztof > Indeed i send patches from different OS with old kernel tree inside, i haven't had idea about that. Will update tree before sending. Regarding v3 which im going to send anyway, should i reword changes in v2? Like in v2 i Adjusted yaml to look the way msm8953 is(seems its wrong). Adjusting examples refers to removing redundant nodes from yaml examples. For sending i use this command: git send-email --to-cover --cc-cover patch-dir/*.patch --cc phone-devel@xxxxxxxxxxxxxxx --cc ~postmarketos/upstreaming@xxxxxxxxxxx --cc-cmd='scripts/get_maintainer.pl --norolestats patch-dir/*.patch' Is switching to any different tool required? I doubt i would be able to do it without making some big mistakes.
