On Tue, 02 Jul 2024 17:34:04 +0000
Guillaume Stols <gstols@xxxxxxxxxxxx> wrote:
> This series adds the following improvements over the current AD7606's
> driver implementation:
>
> - Fix wrong usage of gpio array
> - Fix standby that was documented as ACTIVE_LOW but handled in the
> driver as if it was ACTIVE_HIGH
> - Improve dt-bindings documentation
> - Switch mutex lock to scoped guard
>
> Signed-off-by: Guillaume Stols <gstols@xxxxxxxxxxxx>
This series is blowing up with b4, in that it is finding tags that were
not given and I can't work out why.
Tried various options but even a simple b4 am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@xxxxxxxxxxxx
Is merrily finding tags that I can find no record of.
✓ [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
+ Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> (✓ DKIM/kernel.org)
+ Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-1-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 2/8] dt-bindings: iio: adc: adi,ad7606: improve descriptions
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-2-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 3/8] dt-bindings: iio: adc: adi,ad7606: add supply properties
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-3-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
+ Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> (✓ DKIM/kernel.org)
+ Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-4-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
+ Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-5-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
+ Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> (✓ DKIM/kernel.org)
+ Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
+ Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> (✓ DKIM/kernel.org)
+ Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> (✓ DKIM/kernel.org)
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@xxxxxxxxxxxx
✓ [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
+ Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@xxxxxxxxxxxx
Take patch 7 for example, I can find no record or Rob or Conor replying to that
or giving tags on the cover letter.
The only local parameter I have is to change the link path as you can see above.
Tried it with b4 0.14 and master as of today.
> ---
> Changes in v3:
> - Remove the two first patches that were already picked up.
> - Add styling corrections.
> - [Patch 6/8] Improve commit message.
> - [Patch 8/8] Replace every scoped_guard by simple guard.
> - Link to v2: https://lore.kernel.org/r/20240628-cleanup-ad7606-v2-0-96e02f90256d@xxxxxxxxxxxx
>
> Changes in v2:
> - Change scoped guard to guard(mutex)(&st->lock). This was tested with
> Rob's bot condition, and seems not to generate warning anymore.
> - Reorder the commits for avoiding bisection issues and respect commit
> priority rules.
> - Add vdrive-supply to required properties.
> - Separate cosmetic changes from content ones in dt-binding
> descriptions.
> - Move maxItems changes (and plural in descriptions) to the commit that
> adds conditions.
> - Link to v1: https://lore.kernel.org/r/20240618-cleanup-ad7606-v1-0-f1854d5c779d@xxxxxxxxxxxx
>
> ---
> Guillaume Stols (8):
> dt-bindings: iio: adc: adi,ad7606: normalize textwidth
> dt-bindings: iio: adc: adi,ad7606: improve descriptions
> dt-bindings: iio: adc: adi,ad7606: add supply properties
> dt-bindings: iio: adc: adi,ad7606: fix example
> dt-bindings: iio: adc: adi,ad7606: add conditions
> iio: adc: ad7606: fix oversampling gpio array
> iio: adc: ad7606: fix standby gpio state to match the documentation
> iio: adc: ad7606: switch mutexes to scoped_guard
>
> .../devicetree/bindings/iio/adc/adi,ad7606.yaml | 123 ++++++++++++++++-----
> drivers/iio/adc/ad7606.c | 47 ++++----
> drivers/iio/adc/ad7606_spi.c | 5 +-
> 3 files changed, 115 insertions(+), 60 deletions(-)
> ---
> base-commit: 340fa834ae229a952db04a57ed13fd5d35d75818
> change-id: 20240416-cleanup-ad7606-161e2ed9818b
>
> Best regards,
