On 7/3/24 11:36 AM, Niklas Söderlund wrote:
On 2024-07-03 10:24:26 +0200, Geert Uytterhoeven wrote:Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?It's possible to have a rest-gpios property both in the mdio node and the phy node. The former resets the whole bus while the later a single PHY, at least that's my understanding.
My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .
I think it would be more correct to move the reset-gpios up one level for r8a779g0. However as it already was in the PHY node and this functioned as it should I kept it there. The need for the mdio node was to avoid a device specific property added in the BSP to reset the whole bus. At the moment I can't recall the two different call sites for when the two resets are called. Maybe if we move it to the mdio node we can avoid setting the PHY id in the compatible string as we could then always probe the PHY correctly. I will look into it
Thanks
