> > > > --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > > > > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > > > > @@ -17,6 +17,7 @@ aliases { > > > > gpio1 = &gpio1; > > > > gpio2 = &gpio2; > > > > gpio3 = &gpio3; > > > > + spi0 = &spi0; > > > > > > "spi" would sort after "serial". > > > > > > > serial0 = &uart0; > > > > serial1 = &uart1; > > > > serial2 = &uart2; > > > I'm pretty sceptical about adding more of these fixed clocks, rather > > > than waiting for the clock driver. Drew, what do you think? Should we > > > just add one more to your fixup list or would you rather delay? Guess it > > > depends on how long more you think that clock driver is likely to take. > > > > I think the clk driver [1] is in good shape but it has not been reviewed > > by the clk maintainer yet. Thus it is hard to predict any timeline for > > it getting merged. > > > > SPI support doesn't require any driver changes so I'd be inclined to > > allow the fixed clock in this case. It will be simple to change it over > > to a real clock once the clk driver is upstream. > > > > Acked-by: Drew Fustini <drew@xxxxxxxx> Alright! I do the suggested edits and send a new patch. > > Thanks, > > Drew > > Sorry, I meant to include the link to the most recent clk series: > https://lore.kernel.org/linux-riscv/20240623-th1520-clk-v2-0-ad8d6432d9fb@xxxxxxxxxxxxxxx/ > > -Drew Thanks and Regards, Kanak Shilledar