On Thu, Jul 04, 2024 at 03:29:57PM +0800, Zhaoxiong Lv wrote: > The starry-er88577 is a 10.1" WXGA TFT-LCD panel. Hence, we > add a new compatible with panel specific config. > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > Changes between V5 and V4: > - 1. We are compatible with starry-er88577 panels in the boe-th101mb31ig002 > - driver, so add it to the "boe,th101mb31ig002-28a.yaml". Are you sure that "compatible" is the right word here? It seems like the devices are rather similar, but compatible would mean that the driver would work for both without changes. The driver patch (and the lack of a fallback compatible here) implies that the panels are not actually compatible. Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor. > > v4: https://lore.kernel.org/all/20240620115245.31540-2-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Changes between V4 and V3: > - 1. Move positions to keep the list sorted. > > v3: https://lore.kernel.org/all/20240614145609.25432-2-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Changes between V3 and V2: > - 1. Separate the Starry bindings from kingdisplay, and add it to panel-simple-dsi.yaml > > v2: https://lore.kernel.org/all/20240601084528.22502-4-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Changes between V2 and V1: > - 1. Add compatible for Starry er88577 in Kingdisplay kd101ne3 dt-bindings. > --- > .../bindings/display/panel/boe,th101mb31ig002-28a.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml b/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml > index 32df26cbfeed..2f251703a121 100644 > --- a/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml > +++ b/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml > @@ -17,6 +17,8 @@ properties: > enum: > # BOE TH101MB31IG002-28A 10.1" WXGA TFT LCD panel > - boe,th101mb31ig002-28a > + # The Starry-er88577 is a 10.1" WXGA TFT-LCD panel > + - starry,er88577 > > reg: true > backlight: true > -- > 2.17.1 >
Attachment:
signature.asc
Description: PGP signature
