On 04/07/2024 14:40, Stanislav Jakubek wrote: > Convert the Spreadtrum SC9860 clock bindings to DT schema. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > + - if: > + properties: > + compatible: > + contains: > + enum: > + - sprd,sc9860-aonsecure-clk > + - sprd,sc9860-aon-prediv > + - sprd,sc9860-ap-clk > + - sprd,sc9860-cam-clk > + - sprd,sc9860-disp-clk > + - sprd,sc9860-gpu-clk > + - sprd,sc9860-vsp-clk > + then: > + required: > + - reg properties: sprd,syscon: false > + - if: > + properties: > + compatible: > + contains: > + enum: > + - sprd,sc9860-agcp-gate > + - sprd,sc9860-aon-gate > + - sprd,sc9860-apahb-gate > + - sprd,sc9860-apapb-gate > + - sprd,sc9860-cam-gate > + - sprd,sc9860-disp-gate > + - sprd,sc9860-pll > + - sprd,sc9860-pmu-gate > + - sprd,sc9860-vsp-gate > + then: > + required: > + - sprd,syscon properties: reg: false Best regards, Krzysztof