On Thu, Jul 04, 2024 at 10:52:05AM GMT, Thomas Bonnefille wrote: > > > On 7/4/24 10:39 AM, Krzysztof Kozlowski wrote: > > On 04/07/2024 10:35, Thomas Bonnefille wrote: > > > Hello Krzysztof, > > > Thank you for your feedback > > > > > > On 7/3/24 7:08 AM, Krzysztof Kozlowski wrote: > > > > On 02/07/2024 13:52, Thomas Bonnefille wrote: > > > > > The Sophgo SARADC is a Successive Approximation ADC that can be found in > > > > > the Sophgo SoC. > > > > > > > > > > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@xxxxxxxxxxx> > > > > > --- > > > > > .../bindings/iio/adc/sophgo,cv18xx-saradc.yaml | 51 ++++++++++++++++++++++ > > > > > MAINTAINERS | 5 +++ > > > > > 2 files changed, 56 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/sophgo,cv18xx-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/sophgo,cv18xx-saradc.yaml > > > > > new file mode 100644 > > > > > index 000000000000..21fd5dc8e24e > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/iio/adc/sophgo,cv18xx-saradc.yaml > > > > > @@ -0,0 +1,51 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/iio/adc/sophgo,cv18xx-adc.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Sophgo 3 channels Successive Approximation Analog to Digital Converters > > > > > + > > > > > +maintainers: > > > > > + - Thomas Bonnefille <thomas.bonnefille@xxxxxxxxxxx> > > > > > + > > > > > +description: > > > > > + Datasheet at https://github.com/sophgo/sophgo-doc/releases > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + const: sophgo,cv18xx-saradc > > > > > > > > Except that this was never tested... wild-cards are generally not allowed. > > > > > > > > > > I realized I made a mistake when using the "make dt_binding_check" > > > command, which led to some errors in this dt_binding. I have now > > > addressed all of them, but I'm not sure I understand your comment. > > > > > > I don't see any wildcards in the YAML file. Could you please provide > > > more details on what you expect? > > > > What is "xx"? Sounds like wildcard. I do not see such SoC compatible. > > > > The point of cv18xx is to have a single compatible for all SoCs of the > cv18xx series from Sophgo (cv1800b, cv1812h but also sg2000 and sg2002). I > used that as a reflection of the cv18xx.dtsi used for all those SoCs. > > Should I create multiple compatible for all the SoCs of a same brand ? > You can use cv1800-xxx as a base compatible. Add new compatible when other SoCs have different features. See the tutorial I have wrote: https://github.com/sophgo/linux/wiki/Mainline-patch-How%E2%80%90to Regards, Inochi
