Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board

[Dragan Simic <dsimic@xxxxxxxxxxx>]

Hello Heiko,

Please see a few comments below.

On 2024-07-03 23:05, Heiko Stuebner wrote:
> Add devicetree binding for the Rock 5 ITX board, build around the 
> rk3588.

s/Rock/ROCK/
s/build/built/

> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index d2e887415d5dc..7ddb008f52d1a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -826,6 +826,11 @@ properties:
>            - const: radxa,rock-5b
>            - const: rockchip,rk3588
>
> +      - description: Radxa ROCK 5ITX

s/5ITX/5 ITX/

> +        items:
> +          - const: radxa,rock-5itx

s/5itx/5-itx/

> +          - const: rockchip,rk3588
> +
>        - description: Radxa ROCK S0
>          items:
>            - const: radxa,rock-s0