On 7/2/24 14:54, Markus Elfring wrote:
fdt_num_mem_rsv() may return -FDT_ERR_TRUNCATED.
In this case fdt_pack() should propagate the error code.
1. Please choose imperative wordings for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94
The current subject is an imperative?
2. Would you like to add any tags (like “Fixes” and “Cc”)?
d5db5382c5e5 ("libfdt: Safer access to memory reservations") introduced
the check that returns the error code. But before that we could simply
overrun the buffer. I would not know which patch to blame.
Whom do you want to Cc?
3. How do you think about to use a summary phrase like “Complete error handling
in fdt_pack()”?
Why should I choose a less specific subject?
Best regards
Heinrich
