Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip AC40T08A MIPI Display panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 02, 2024 at 04:47:39AM +0000, Manikandan.M@xxxxxxxxxxxxx wrote:
> Hi Conor,
> 
> On 01/07/24 3:33 pm, Conor Dooley wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > 
> > ForwardedMessage.eml
> > 
> > Subject:
> > Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip 
> > AC40T08A MIPI Display panel
> > From:
> > Conor Dooley <conor@xxxxxxxxxx>
> > Date:
> > 01/07/24, 3:33 pm
> > 
> > To:
> > Manikandan Muralidharan <manikandan.m@xxxxxxxxxxxxx>
> > CC:
> > megi@xxxxxx, javierm@xxxxxxxxxx, neil.armstrong@xxxxxxxxxx, 
> > quic_jesszhan@xxxxxxxxxxx, sam@xxxxxxxxxxxx, airlied@xxxxxxxxx, 
> > daniel@xxxxxxxx, maarten.lankhorst@xxxxxxxxxxxxxxx, mripard@xxxxxxxxxx, 
> > tzimmermann@xxxxxxx, robh@xxxxxxxxxx, krzk+dt@xxxxxxxxxx, 
> > conor+dt@xxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, 
> > devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> > 
> > 

btw, please fix your mail client :/

> > On Mon, Jul 01, 2024 at 02:28:35PM +0530, Manikandan Muralidharan wrote:
> >> Add compatible string for the Microchip's AC40T08A MIPI Display
> >> panel.This panel uses a Himax HX8394 display controller.
> >> The reset line is not populated and leads to driver probe issues,
> >> thus add conditional block to narrow reset-gpio property per variant.
> > I really should have asked on v1, but I wasn't sure whether or not the
> > optional nature of the reset-gpios was specific to your new panel so I
> > held off: Is it ever the case that a reset-gpio can be provided for this
> > microchip panel, or just not in the configuration you tested? If it is
> > never possible, then I'd probably do...
> The reset-gpio line can be provided for the microchip MIPI panel, the 
> SoC variant in which I tested did not have the reset line configured, 
> hence had to make it optional here and also in the driver to avoid panel 
> probe issues.

Okay, then:
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux