Rob/Krzysztof, Haylen, On Tue, Jul 02, 2024 at 09:30:24AM +0000, Haylen Chu wrote: > Add devicetree binding documentation for thermal sensors integrated in > Sophgo CV180X SoCs. > > Signed-off-by: Haylen Chu <heylenay@xxxxxxxxxxx> > --- > .../thermal/sophgo,cv1800-thermal.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > new file mode 100644 > index 000000000000..016299822c16 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo CV1800 on-SoC Thermal Sensor > + > +maintainers: > + - Haylen Chu <heylenay@xxxxxxxxxxx> > + > +description: Binding for Sophgo CV1800 on-SoC thermal sensor > + > +properties: > + compatible: > + enum: > + - sophgo,cv1800-thermal > + > + reg: > + maxItems: 1 > + > + clocks: > + description: The thermal sensor clock > + > + interrupts: > + maxItems: 1 > + > + accumulation-period: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Accumulation period for a sample > + enum: > + - 512 > + - 1024 > + - 2048 > + - 4096 > + default: 2048 > + > + chop-period: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: ADC chop period > + enum: > + - 128 > + - 256 > + - 512 > + - 1024 > + default: 1024 > + > + sample-cycle-us: the more common term btw would be "sample-rate" rather than "sample-cycle". > + description: Period between samples. Should be greater than 524us. The constraint here should be "minimum: 524". What's the upper limit? > + default: 1000000 Rob/Krzysztof, could you comment on the suitability of the three custom properties here? I know if this was an IIO device, these kinds of things would be controllable from userspace, and not in the binding. I mentioned this on the previous version, but I'm not really sure if thermal devices are somehow different: https://lore.kernel.org/all/SEYPR01MB4221A739D0645EF0255336EBD7CE2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Cheers, Conor. > + > + '#thermal-sensor-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/sophgo,cv1800.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + thermal-sensor@30e0000 { > + compatible = "sophgo,cv1800-thermal"; > + reg = <0x30e0000 0x100>; > + clocks = <&clk CLK_TEMPSEN>; > + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>; > + #thermal-sensor-cells = <0>; > + }; > +... > -- > 2.45.2 >
Attachment:
signature.asc
Description: PGP signature
