Hi, Thank you for the review! On 6/26/24 14:35, Florian Fainelli wrote: > > > On 26/06/2024 11:45, Stanimir Varbanov wrote: >> Adds DT bindings for bcm2712 MSI-X interrupt peripheral controller. >> >> Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx> <cut> >> +description: > >> + This interrupt controller is used to provide intterupt vectors to the >> + generic interrupt controller (GIC) on bcm2712. It will be used as >> + external MSI-X controller for PCIe root complex. >> + >> +allOf: >> + - $ref: /schemas/interrupt-controller/msi-controller.yaml# >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - "brcm,bcm2712-mip-intc" >> + reg: >> + maxItems: 1 >> + description: > >> + Specifies the base physical address and size of the registers >> + >> + interrupt-controller: true >> + >> + "#interrupt-cells": >> + const: 2 > > Should we have some sort of an interrupt-map or interrupt-map-mask > property that defines the "linkage" between the inputs and the outputs? > This controller does not really sit at the top-level of the interrupt > tree as it feeds the ARM GIC, unfortunately this is not captured at all, > and it seems to require ad-hoc properties to establish the mapping, that > does not seem ideal. Thank you for the suggestion. I will consider it. ~Stan
