> Subject: Re: [PATCH 3/7] arm64: dts: imx95-19x19-evk: Add audio > related nodes > > On Fri, Jun 28, 2024 at 12:03:27AM +0000, Peng Fan wrote: > > > Subject: [PATCH 3/7] arm64: dts: imx95-19x19-evk: Add audio > related > > > nodes > > > > > > Add sai1, sai2. Add i2c4 and wm8962 and other dependent nodes. > > > > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > > --- > > > .../boot/dts/freescale/imx95-19x19-evk.dts | 238 > > > ++++++++++++++++++ > > > 1 file changed, 238 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts > > > b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts > > > index d14a54ab4fd47..660e623f4f964 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts > > > +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts > > > @@ -17,6 +17,11 @@ aliases { > > > serial0 = &lpuart1; > > > }; > > > > ... > > > + 0x0000 /* 4:FN_DMICCDAT */ > > > + 0x0000 /* 5:Default */ > > > + >; > > > + }; > > > + > > > + i2c4_gpio_expander_21: gpio@21 { > > > > Use gpio-expander@21? > > It is easy to duplicate the node if other i2c bus also has one. > > It should be fine, parent node is difference. gpio-expander@21 can't > resolve your problem. > > i2c2 > { > gpio-expander@21 {}; > } > > i2c3 > { > gpio-expander@21 {}; > } > > It should be same situation as gpio@21. > > DT should allow the same name under difference parent. As I recall, there is build error of duplicated node. Regards, Peng. > > Frank > > > > > Regards, > > Peng. > >