On Mon, Jul 01, 2024 at 04:04:51PM +0100, Utsav Agarwal via B4 Relay wrote:
> From: Utsav Agarwal <utsav.agarwal@xxxxxxxxxx>
>
> Updating dt bindings for adp5588. Following properties are now made
> optional:
> - interrupts
> - keypad,num-rows
> - keypad,num-columns
> - linux,keymap
> The proposed new property "gpio-only" has been added as an optional
> property with an additional example.
I can see that as it is clear in the diff, but this doesn't explain why,
which is what you need to do in your commit message.
>
> Signed-off-by: Utsav Agarwal <utsav.agarwal@xxxxxxxxxx>
> ---
> .../devicetree/bindings/input/adi,adp5588.yaml | 28 ++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/adi,adp5588.yaml b/Documentation/devicetree/bindings/input/adi,adp5588.yaml
> index 26ea66834ae2..158fbf02cc16 100644
> --- a/Documentation/devicetree/bindings/input/adi,adp5588.yaml
> +++ b/Documentation/devicetree/bindings/input/adi,adp5588.yaml
> @@ -46,6 +46,11 @@ properties:
> '#gpio-cells':
> const: 2
>
> + gpio-only:
> + description:
> + This property applies if keypad,num-rows, keypad,num-columns and
> + linux,keypad are not specified. All keys will be marked as gpio.
Why is a property required for this? Is the absence of the 3 keypad
properties not sufficient to determine that you're in this mode?
> interrupt-controller:
> description:
> This property applies if either keypad,num-rows lower than 8 or
> @@ -68,10 +73,6 @@ properties:
> required:
> - compatible
> - reg
> - - interrupts
I don't understand why interrupts is no longer required.
> - - keypad,num-rows
> - - keypad,num-columns
> - - linux,keymap
I think you should configure "dependencies:" such that if one of these
properties is added, then all 3 of them must be to preserve the current
requirements while the device is being used in keypad mode.
Thanks,
Conor.
>
> unevaluatedProperties: false
>
> @@ -108,4 +109,23 @@ examples:
> >;
> };
> };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/input/input.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio@34 {
> + compatible = "adi,adp5588";
> + reg = <0x34>;
> +
> + #gpio-cells = <2>;
> + gpio-controller;
> + gpio-only;
> + };
> + };
> +
> ...
>
> --
> 2.34.1
>
>
Attachment:
signature.asc
Description: PGP signature
