FUKAUMI Naoki wrote: > Milk-V Mars has a green LED to show system load[1]. This patch enables > a green LED as a heartbeat LED. > > Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxx> > > [1] https://github.com/milkv-mars/mars-buildroot-sdk/blob/dev/linux/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dtsi#L79 > > Changes in v3: > - add default-state = "on" to turn LED on at U-Boot (not enabled yet) > Changes in v2: > - reorder properties in led-0 > --- > arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts > index 5cb9e99e1dac..5cae7a5d2f86 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts > +++ b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts > @@ -4,11 +4,25 @@ > */ > > /dts-v1/; > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/leds/common.h> > #include "jh7110-common.dtsi" > > / { > model = "Milk-V Mars"; > compatible = "milkv,mars", "starfive,jh7110"; > + > + leds { > + compatible = "gpio-leds"; > + > + led-0 { > + gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>; > + color = <LED_COLOR_ID_GREEN>; > + default-state = "on"; > + function = LED_FUNCTION_HEARTBEAT; > + linux,default-trigger = "heartbeat"; > + }; > + }; Hi Naoki Thanks for adding the other boards too. As mentioned previously [1] boards should not add functions to LEDs unless the hardware clearly defines a function for them, and nothing on these boards mention that it should be a heartbeeat. As you said on IRC userland can easily add whatever function they want. Also please add a cover letter when you're sending multiple patches. Eg. use git format-patch --cover-letter /Emil [1]: https://lore.kernel.org/linux-riscv/CAJM55Z_j8gWFyKvsiu-oGDV7Hacr4Amt5FdkHdjKnhZwZgxncA@xxxxxxxxxxxxxx/ > }; > > &gmac0 { > -- > 2.43.0 >
