On 28/06/2024 23:17, Spencer Hill wrote:
> Add bindings for Sony IMX728.
>
> Signed-off-by: Spencer Hill <shill@xxxxxxxxxxxxxxxxx>
> +
> + clocks:
> + description: Clock frequency from 18 to 30MHz
> + maxItems: 1
> +
> + clock-names:
> + const: inck
clock-names do not seem that useful - name is pretty obvious. Drop.
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + Specifier for the GPIO connected to the XCLR (System Reset) pin.
> +
> + avdd-supply:
> + description: Analog power supply (3.3V)
> +
> + dvdd-supply:
> + description: Digital core power supply (1.1V)
> +
> + ovdd-supply:
> + description: Digital I/O power supply (1.8V)
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: ../video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + link-frequencies: true
Drop, not needed.
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + clock-frequency = <400000>;
Drop
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@1a {
> + compatible = "sony,imx728";
> + reg = <0x1a>;
> +
> + clocks = <&fixed_clock>;
> + clock-names = "inck";
> +
> + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> +
> + avdd-supply = <&camera_vdda_3v3>;
> + dvdd-supply = <&camera_vddd_1v1>;
> + ovdd-supply = <&camera_vddo_1v8>;
> +
> + port {
> + camera1: endpoint {
> + remote-endpoint = <&csi2_phy0>;
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <800000000>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef6be9d95143..a2811249ac8c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20589,6 +20589,13 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> F: drivers/media/i2c/imx415.c
>
> +SONY IMX728 SENSOR DRIVER
> +M: Spencer Hill <shill@xxxxxxxxxxxxxxxxx>
> +L: linux-media@xxxxxxxxxxxxxxx
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
> +F: drivers/media/i2c/imx728.c
There is no such file. Patches must be bisectable.
Best regards,
Krzysztof
